Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect padding between frame images when packing sprite sheets (fix aseprite/aseprite#3993) #64

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

Gasparoken
Copy link
Member

Prior to this fix, Export Sprite Sheet incorrectly generated a shape padding in some frame image when the following options were chosen:

  • Packed sheet type
  • Trim Cels
  • Spacing > 0

fix aseprite/aseprite#3993

@Gasparoken Gasparoken self-assigned this Aug 4, 2023
@Gasparoken
Copy link
Member Author

Gasparoken commented Aug 4, 2023

Pending: tests and border padding fix: aseprite/aseprite#3997

@Gasparoken Gasparoken marked this pull request as ready for review August 10, 2023 17:44
fix aseprite/aseprite#3993)

Prior to this fix, the shape padding generated by 'Export Sprite Sheet'
overlapped on some frame images when the following options were chosen:
- Packed sheet type
- Trim Cels = true
- Spacing > 0 (shape padding > 0)
@Gasparoken Gasparoken assigned dacap and unassigned Gasparoken Aug 11, 2023
@Gasparoken Gasparoken requested a review from dacap August 11, 2023 19:36
@Gasparoken
Copy link
Member Author

Gasparoken commented Aug 11, 2023

@dacap I think it's ready to merge.

@nklbdev
Copy link

nklbdev commented Sep 22, 2023

You are awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aseprite sometimes incorrectly handles paddings between sprites and whole sheet when packing sprite sheets
4 participants